Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCRUM-4657: add references to Variant FMS load #1788

Merged
merged 4 commits into from
Jan 10, 2025
Merged

SCRUM-4657: add references to Variant FMS load #1788

merged 4 commits into from
Jan 10, 2025

Conversation

abecerra
Copy link
Contributor

@abecerra abecerra commented Jan 9, 2025

No description provided.

markquintontulloch
markquintontulloch requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@markquintontulloch markquintontulloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should really also have integration tests for updates with missing/empty references list. These would have caught the bug in the validation code.

As adding the column to the UI, also need to add a UI test to the VariantsTable.test

...java/org/alliancegenome/curation_api/services/validation/dto/fms/VariantFmsDTOValidator.java Show resolved Hide resolved
src/test/java/org/alliancegenome/curation_api/VariantFmsITCase.java Show resolved Hide resolved
src/test/java/org/alliancegenome/curation_api/VariantFmsITCase.java Show resolved Hide resolved
@markquintontulloch
Copy link
Member

Should really also have integration tests for updates with missing/empty references list. These would have caught the bug in the validation code.

As adding the column to the UI, also need to add a UI test to the VariantsTable.test

@abecerra These comments still need to be addressed

@abecerra abecerra merged commit 4e810c1 into alpha Jan 10, 2025
10 checks passed
@abecerra abecerra deleted the SCRUM-4657 branch January 10, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markquintontulloch markquintontulloch markquintontulloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abecerra @markquintontulloch