SCRUM-4436 integration test fix #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SCRUM-3953 (update) Fix record counts
SCRUM-4608 Fix counts for disease annotation loads
SCRUM-4607 add sticky header to data loads page
cmpich
approved these changes
Nov 25, 2024
|
yes, I merged alpha into the branch I was working on so there's some unrelated changes |
cmpich
reviewed
Nov 26, 2024
| @@ -22,7 +22,8 @@ public class EvidenceAssociationDTOValidator extends BaseDTOValidator { | |||
|
|
|||
| public <E extends EvidenceAssociation, D extends EvidenceAssociationDTO> ObjectResponse<E> validateEvidenceAssociationDTO(E association, D dto) { | |||
| ObjectResponse<E> assocResponse = validateAuditedObjectDTO(association, dto); | |||
|
|
|||
| association = assocResponse.getEntity(); | |||
There was a problem hiding this comment.
The association is directly changed in the validateAuditedObjectDTO, so need to pull it off the ObjectResponse.
There was a problem hiding this comment.
Yep, sorry - I misread the change and thought this was being removed instead of added
There was a problem hiding this comment.
Oh hang on, this is my PR. So yes, this needed to be added for that reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all integration tests