Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCRUM-3952: change vocabularyterm to ontologyterm after LinkML change #1667

Merged
merged 5 commits into from
Sep 20, 2024
Merged

SCRUM-3952: change vocabularyterm to ontologyterm after LinkML change #1667

merged 5 commits into from
Sep 20, 2024

Conversation

abecerra
Copy link
Contributor

No description provided.

markquintontulloch
markquintontulloch reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@markquintontulloch markquintontulloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AnatomicalSite entity class needs the @AGRCurationSchemaVersion annotation updated to a min of 2.7.0 - you will also need to increase the LinkMLSchemaConstants.LATEST_RELEASE constant to this value

@markquintontulloch
Copy link
Member

I'm guessing you also need to update the integration tests to use ontology terms instead of vocabulary terms

@abecerra abecerra force-pushed the SCRUM-3952 branch 2 times, most recently from 706622c to d28cc2e Compare September 19, 2024 15:16
@abecerra
Copy link
Contributor Author

The AnatomicalSite entity class needs the @AGRCurationSchemaVersion annotation updated to a min of 2.7.0 - you will also need to increase the LinkMLSchemaConstants.LATEST_RELEASE constant to this value

Done

@abecerra abecerra merged commit 326905b into alpha Sep 20, 2024
10 checks passed
@abecerra abecerra deleted the SCRUM-3952 branch September 20, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markquintontulloch markquintontulloch markquintontulloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abecerra @markquintontulloch