Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier #1574

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Add prettier #1574

merged 9 commits into from
Jun 19, 2024

Conversation

adamgibs
Copy link
Contributor

@adamgibs adamgibs commented Jun 19, 2024

Prettier formatter has been added and JS files have been updated. There is a formatting check in GH actions that fails if any JS files are incorrectly formatted along with two make targets, prettier-check that validates formatting and prettier-write which updates formatting. Formatting rules can be changed in the .prettierrc.yaml file

@oblodgett
Copy link
Member

@adamgibs did your editor help with this or did you have to do it by hand? Thats a lot of edits.

@oblodgett
Copy link
Member

oblodgett commented Jun 19, 2024

PS is there a make jslint or uilint or something that can be run via the command line before committing?

@adamgibs
Copy link
Contributor Author

adamgibs commented Jun 19, 2024

@oblodgett I've added a Makefile target prettier-write that updates the formatting. I didn't use the editor for code updates, only the command line. Also, you'll need to run npm install or npm ci after pulling the branch locally.

@oblodgett oblodgett merged commit 811d6cf into alpha Jun 19, 2024
6 checks passed
@oblodgett oblodgett deleted the add-prettier branch June 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants