Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change update message for DTO loads #1540

Merged
merged 4 commits into from
May 23, 2024
Merged

Change update message for DTO loads #1540

merged 4 commits into from
May 23, 2024

Conversation

markquintontulloch
Copy link
Member

@markquintontulloch markquintontulloch commented May 23, 2024 •
edited by oblodgett
Loading

@oblodgett Can we change this message? "GeneService_ClientProxy updating GeneDTO" is a bit cryptic and doesn't identify the data provider

@oblodgett
Copy link
Member

oblodgett commented May 23, 2024 •
edited
Loading

Sure, however there is not always a data provider and trying to keep it generic. but ya this looks good. objectList.size(); should be pulled out of the message and added a param to the startProcess method.

@oblodgett oblodgett enabled auto-merge May 23, 2024 09:13
@oblodgett oblodgett disabled auto-merge May 23, 2024 09:14
@markquintontulloch markquintontulloch merged commit 24708b7 into alpha May 23, 2024
5 checks passed
@markquintontulloch markquintontulloch deleted the update_message branch May 23, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oblodgett oblodgett oblodgett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markquintontulloch @oblodgett