Skip to content
This repository has been archived by the owner on Feb 19, 2024. It is now read-only.

Fix bug with util package breaking in the browser #588

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

ostowe
Copy link
Contributor

@ostowe ostowe commented Jul 23, 2021

Issue(s): Relates to or closes...

See browserify/node-util#43

Summary: This pull request will...

  • Add fallback for util to irving core (in addition to the vip-go package, which already has it)
  • Add ProvidePlugin to client builds to provide the process/browser package

Tests: I know this code works because...

Tested locally

Copy link
Contributor

@justinwhall justinwhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ostowe ostowe merged commit e626316 into main Jul 23, 2021
@ostowe ostowe deleted the bug/logservice-browser branch July 23, 2021 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants