node 6 breaks this #1

mcarifio · 2016-05-10T18:14:30Z

First, ty for a useful module.

Next, for node 6:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 16.04 LTS
Release: 16.04
Codename: xenial

$ node --version
v6.1.0

$ node

var Av = require('autovivify');
undefined
var used = new Av();
undefined
used.x.y =1
1
used.x
{ y: 1 }
used
{ x: { y: 1 } }

Object.prototype.toString.call(used) // no toString() method?, how do I find the actual type of 'used'?
terminate called after throwing an instance of 'std::logic_error'
what(): basic_string::_M_construct null not valid
Aborted

allenluce · 2016-05-12T00:30:26Z

Looks like this is sensitive to a change in v8 between 4.8.271.17 and 4.9.385.18. I was able to confirm that this breaks with node's commit 079973b96 (and works on 893835539). Updating nan/node-gyp didn't magically fix it, so I guess it's going to take a little more digging.

This is to address #1 Some change occurred between the node repo's commits 893835539 and 079973b96 (corresponding to v8 versions 4.8.271.17 and 4.9.385.18) that makes toString() cause node to die with a `basic_string::_S_construct NULL not valid` error message. It seems that the new node.js calls the property getter with an invalid property address to query (after first calling for a toString property on instance and object). This causes the fault. It's not 100% clear what's happening, but adding a toString() method gets some functionality working. Using Object.prototype.toString.call() on the object still bombs.

allenluce · 2016-05-12T01:37:01Z

I'm still not totally sure what is going on but did add a toString() method. In previous versions, v8 compensates for the lack of one on the embedded object but that seems to have broken with the newer versions.

1.0.5 is now up. Object.prototype.toString() still bombs when applied to an autovivified object but the .toString() method on the object itself no longer does. Let me know if that fits your use.

allenluce · 2016-06-02T21:57:14Z

OK, figured it out. The 1.0.6 version should no longer bomb on Object.prototype.toString.call(). Type returns as '[object AutoVivify]'. If there's a call to have it masquerade as a '[object Object]' I can probably build that in.

This is to address #1 Some change occurred between the node repo's commits 893835539 and 079973b96 (corresponding to v8 versions 4.8.271.17 and 4.9.385.18) that makes toString() cause node to die with a `basic_string::_S_construct NULL not valid` error message. It seems that the new node.js calls the property getter with an invalid property address to query (after first calling for a toString property on instance and object). This causes the fault. It's not 100% clear what's happening, but adding a toString() method gets some functionality working. Using Object.prototype.toString.call() on the object still bombs.

So when Node 6+ wants to do an Object.prototype.toString call, it first sends a query for a property (the GetToStringTag property, in particular). Autovivify didn't know how to deal with this query, so would bomb. This has the property getter just return if it's asked for a symbol. This lets v8 fall through to its own stringify routines, so an appropriate value is emitted ("[object AutoVivify]"). This also removes the explicit toString method as the existing fall-back one seems to work just fine. This fixes #1

allenluce closed this as completed in 4400a99 Jun 2, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

node 6 breaks this #1

node 6 breaks this #1

mcarifio commented May 10, 2016

allenluce commented May 12, 2016

allenluce commented May 12, 2016 •

edited

Loading

allenluce commented Jun 2, 2016

node 6 breaks this #1

node 6 breaks this #1

Comments

mcarifio commented May 10, 2016

allenluce commented May 12, 2016

allenluce commented May 12, 2016 • edited Loading

allenluce commented Jun 2, 2016

allenluce commented May 12, 2016 •

edited

Loading