Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add progress bar to http_get #496

Closed
wants to merge 2 commits into from
Closed

Conversation

WeixiongLin
Copy link
Contributor

I have discussed with the maintainer in issue-490, and encouraged to raise this PR.

Gist:
To use scispacy, some of the resources are fetched from web url, e.g. URL of tfidf_vectors_sparse. And the size of the resources could be up to 500M, thereby taking several miutes to complete downloading. Somehow scispacy download quietly without signals for users, so thet can't tell whether the progress stucks or not.

So I add a progress bar to the function http_get to let users know where they are.

Scispacy helps me a lot in my research, thanks for your contribution to our community. And thanks for your review.

Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run the autoformatter? black scispacy --line-length 88

Otherwise, looks good to me, thank you!

@WeixiongLin
Copy link
Contributor Author

Could you run the autoformatter? black scispacy --line-length 88

Otherwise, looks good to me, thank you!

OK.

@WeixiongLin
Copy link
Contributor Author

There's something wrong with my downstream repo, I have to close this PR and raise a new one.
I have run the black formatter by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants