Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added index checking to hyponym_detector.py #282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added index checking to hyponym_detector.py #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scispacy/hyponym_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ def expand_to_noun_compound(self, token: Token, doc: Doc):

start = token.i
while True:
if start==0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add spaces between symbols, (our linter requires it), like if start == 0:

break
previous = doc[start - 1]
if previous.pos_ in {"PROPN", "NOUN", "PRON"}:
start -= 1
Expand All @@ -70,7 +72,10 @@ def expand_to_noun_compound(self, token: Token, doc: Doc):

end = token.i + 1
while True:
previous = doc[end]
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using try/except here, could you get the length of the doc before this while loop (len(doc)) and check against it each time? It's more explicit and doesn't silently catch other index errors that may be thrown e.g within spacy.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Should have time to make these updates shortly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, contributions are always welcome regardless of timeframe :)

previous = doc[end]
except IndexError:
break
if previous.pos_ in {"PROPN", "NOUN", "PRON"}:
end += 1
else:
Expand Down