This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Explicitly pass serialization directory and local rank to trainer in train command #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgr
suggested changes
May 5, 2021
epwalsh
changed the title
|
Ok, so this wasn't a bug after all. Apparently This blows my mind, and I'm not really comfortable with it. So I've made it explicit and added a test to ensure the behavior never breaks. |
dirkgr
added a commit
that referenced
this pull request
May 10, 2021
…train command (#5180) * fix bug with local_rank * fix up Co-authored-by: Dirk Groeneveld <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thelocal_rankwas never actually passed to the trainer.