This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
PIQA in Tango #294
Merged
PIQA in Tango #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
This LGTM, but I have some minor fixes in this PR: allenai/allennlp#5350
epwalsh
reviewed
Aug 10, 2021
training_config/tango/piqa.jsonnet
Outdated
Comment on lines
16
to
17
| "type": "max_batches", | ||
| [if debug then "max_batches_per_epoch"]: 7, |
There was a problem hiding this comment.
I think this breaks when debug is false since max_batches_per_epoch is a required argument for this data loader.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.