Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Remove registered_predictor_name from all modelcards where the predictor is the same as the default #253

Merged
merged 3 commits into from
Apr 19, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Tests for the VQA metric

### Changed

- Updated `registered_predictor_name` to `null` in model cards for the models where it was the same as the default predictor.


## [v2.3.0](https://github.com/allenai/allennlp-models/releases/tag/v2.3.0) - 2021-04-14

Expand Down
2 changes: 1 addition & 1 deletion allennlp_models/modelcards/mc-roberta-commonsenseqa.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "mc-roberta-commonsenseqa",
"registered_model_name": "transformer_mc",
"registered_predictor_name": "transformer_mc",
"registered_predictor_name": null,
"display_name": "RoBERTa Common Sense QA",
"task_id": "mc",
"model_details": {
Expand Down
2 changes: 1 addition & 1 deletion allennlp_models/modelcards/mc-roberta-piqa.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "mc-roberta-piqa",
"registered_model_name": "transformer_mc",
"registered_predictor_name": "transformer_mc",
"registered_predictor_name": null,
"display_name": "Physical Interaction Question Answering",
"task_id": "mc",
"model_details": {
Expand Down
2 changes: 1 addition & 1 deletion allennlp_models/modelcards/mc-roberta-swag.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "mc-roberta-swag",
"registered_model_name": "transformer_mc",
"registered_predictor_name": "transformer_mc",
"registered_predictor_name": null,
"display_name": "RoBERTa SWAG",
"task_id": "mc",
"model_details": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "pair-classification-decomposable-attention-elmo",
"registered_model_name": "decomposable_attention",
"registered_predictor_name": "textual_entailment",
"registered_predictor_name": null,
"display_name": "ELMo-based Decomposable Attention",
"task_id": "textual_entailment",
"model_details": {
Expand Down
2 changes: 1 addition & 1 deletion allennlp_models/modelcards/pair-classification-esim.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "pair-classification-esim",
"registered_model_name": "esim",
"registered_predictor_name": "textual_entailment",
"registered_predictor_name": null,
"display_name": "Enhanced LSTM for Natural Language Inference",
"task_id": "textual_entailment",
"model_details": {
Expand Down
4 changes: 2 additions & 2 deletions allennlp_models/modelcards/ve-vilbert.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "ve-vilbert",
"registered_model_name": "visual-entailment",
"registered_predictor_name": "vilbert_ve",
"registered_model_name": "ve_vilbert",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

"registered_predictor_name": null,
"display_name": "Visual Entailment",
"task_id": "ve",
"model_details": {
Expand Down
2 changes: 1 addition & 1 deletion allennlp_models/modelcards/vqa-vilbert.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "vqa-vilbert",
"registered_model_name": "vqa_vilbert",
"registered_predictor_name": "vilbert_vqa",
"registered_predictor_name": null,
"display_name": "ViLBERT - Visual Question Answering",
"task_id": "vqa",
"model_details": {
Expand Down
1 change: 1 addition & 0 deletions allennlp_models/pretrained.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from allennlp_models.rc.models import * # noqa: F401, F403
from allennlp_models.structured_prediction.models import * # noqa: F401, F403
from allennlp_models.tagging.models import * # noqa: F401, F403
from allennlp_models.vision.models import * # noqa: F401, F403


def get_tasks() -> Dict[str, TaskCard]:
Expand Down