Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference agent fix, improvements when using NCCL backend, and other minor improvements. #345

Merged
merged 11 commits into from
Jun 2, 2022

Conversation

Lucaweihs
Copy link
Collaborator

This PR makes the following changes:

  • Fixes some problems with the inference agent that occurred when resetting the agent.
  • Adds a read timeout to calls to vector sampled tasks so that the training process will exit correctly if the vector sampled tasks fails to respond for some amount of time (currently 1 minute but this may be too low).
  • Adds experimental code to restart vector sampled tasks if an environment ever happens to throw an uncaught error. This functionality is disabled by default.
  • Adds a new habitat experiment and HM3D support.
  • Improves the vision sensor to ensure that it copies images before modifing them (necessary for the new version of ai2thor)
  • A few other minor fixes.

@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request introduces 1 alert when merging 21b663a into 474fb84 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Apr 28, 2022

This pull request introduces 1 alert when merging 481c449 into 474fb84 - view on LGTM.com

new alerts:

  • 1 for Unused import

@Lucaweihs Lucaweihs merged commit a709009 into main Jun 2, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2022

This pull request introduces 1 alert when merging 1d3c64a into 474fb84 - view on LGTM.com

new alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant