Better error message when passing in unknown scene #977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a pretty ugly error message on

main
when an unknown scene in passed in:The error message occurs because we try to sort by the pattern
re.search(r"FloorPlan[_]?([a-zA-Z\-]*)([0-9]+)_?([0-9]+)?.*$", scene_name)
. But, not all scenes in themain
build work with the pattern anymore. For instance, trying it withFloorPlan_ExpRoom
results inNone
, which then results in the AttributeError:'NoneType' object has no attribute 'group'
.This PR just calls
sorted()
instead of trying to sort bykey_sort_func
. The downside is that it may be a little less natural, whereFloorPlan10
might come beforeFloorPlan1
, but it's much more robust to new scene names in the build.Full notebook: https://colab.research.google.com/drive/1207Px1enUPqzJ2mTIkvrc-OA7eygpEyT?usp=sharing