Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python+WSGI -> Unity Editor #958

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Fix Python+WSGI -> Unity Editor #958

merged 1 commit into from
Jan 19, 2022

Conversation

ekolve
Copy link

@ekolve ekolve commented Dec 15, 2021

Calls to ChangeResolution fail when connecting from Python to the Unity Editor. This PR resolves that.

adding check for unity_proc prior to calling ChangeResolution to hand…
6f00529 
…le case when Python client is running against the Unity Editor
@ekolve ekolve requested a review from mattdeitke December 15, 2021 23:39
mattdeitke
mattdeitke approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@mattdeitke mattdeitke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekolve ekolve merged commit 35ab2a1 into main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winthos winthos winthos approved these changes

@mattdeitke mattdeitke mattdeitke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekolve @winthos @mattdeitke