Prefab alignment fix #919
Merged
Prefab alignment fix #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 17e2855.
…Light Switches, Shower Curtains, Shower Heads, Soap Bars, Spray Bottles, Toilets, Toilet Paper, Toilet Paper Hangers, Bath Towels, Towel Holders, Alarm Clocks, and Liquid Caps
elimvb
requested review from
winthos,
mattdeitke,
ekolve and
roozbehm
and removed request for
roozbehm
removing leftover meta file since it seems `TEMP_STUFF` has been deleted
the `Controlled Sim Objects` array in the `CanToggleOnOff` component of this stove knob had size 1 but no object referenced by default. Reset to size 0 by default
|
LGTM! Really nice work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of several significant changes to our prefab asset library. It includes several major revamps:
All SimObjects have their positions, rotations, and scales zeroed out, and their fronts oriented in the local z-forward direction
All SourcePrefabs are severed from the main prefabs, and subsequently deleted
All "THORKEA" assets have been renamed to "RoboTHOR" assets
Various prefabs are have been renamed slightly for project consistency
Many other redundant prefabs are deleted, including the entire outdated SimObjs folder, among others
All iTHOR and RoboTHOR scenes have been adjusted and settled, based on these prefab corrections