Stretch robot restructured arm updated #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature. Work-in-progress.
…seFPSAgentController
…keep logic consistent with Stretch Arm's
…, and fixed Stretch Arm base's center-of-rotation
-moved NavMeshAgent to child object so we can offset it accordingly with Stretch bot's weird center of rotation
elimvb
requested review from
ekolve,
Lucaweihs,
ehsanik,
AlvaroHG,
winthos and
mattdeitke
|
This pull request introduces 7 alerts and fixes 1 when merging b25593b into e6d9146 - view on LGTM.com new alerts:
fixed alerts:
|
winthos
approved these changes
Oct 13, 2021
winthos
approved these changes
Nov 18, 2021
|
This pull request introduces 7 alerts and fixes 1 when merging d2688ff into 2f73b6a - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 7 alerts and fixes 1 when merging 482d1ce into 2f73b6a - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 7 alerts and fixes 1 when merging 879ad7c into 2f73b6a - view on LGTM.com new alerts:
fixed alerts:
|
… without caching anything
…rameter-dependent
|
This pull request introduces 7 alerts and fixes 2 when merging 7184aa4 into db85652 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A comprehensive addition to our agent: a new Stretch Robot-type, complete with dedicated logic. This also includes some hierarchical changes to the IK-arm to consolidate the logic for backend ease-of-use, but it remains functionally identical.