Changing the maxUpwardLookAngle of the locobot so that it can look upwards by up to 30 degrees. #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wards by up to 30 degrees.
…downwards by up to 60 degrees.
winthos
requested changes
May 3, 2022
winthos
reviewed
May 4, 2022
winthos
approved these changes
May 4, 2022
mattdeitke
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a change made several months ago and allows the locobot to look upwards above the horizon line.
This PR also allows the locobot to look downwards by up to 60 degrees as is mentioned in the documentation.