Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged procthor code #39

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Less verbosity in make_valid_houses_file
jordis-ai2 committed Sep 13, 2022
commit 956c445a13dcc3b48f171eb419cecf49183097f8
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -170,8 +170,8 @@ a local `./src` directory. By explicitly specifying the `PIP_SRC` variable we ca

### Install original episodes datasets

To download pre-generated training, validation and test datasets for rearrangement in iTHOR, from the project's root
directory call:
We need to download pre-generated training, validation and test datasets for rearrangement in iTHOR. From the project's
root directory, call:
```bash
inv install-ithor-dataset -d 2022
```
@@ -592,7 +592,7 @@ We also provide scripts to generate new ProcTHOR datasets in case you want to tr
#### Install original dataset

To download pre-generated training and validation datasets for rearrangement in ProcTHOR, from the project's root
directory call:
directory, call:
```bash
inv install-procthor-dataset
```
12 changes: 8 additions & 4 deletions tasks.py
Original file line number Diff line number Diff line change
@@ -356,7 +356,9 @@ def make_procthor_mini_val(


@task
def make_valid_houses_file(ctx, num_valid_houses=1_000, prefix="mini_val"):
def make_valid_houses_file(
ctx, num_valid_houses=1_000, prefix="mini_val", verbose=True
):
used_houses = [None] * num_valid_houses # Assume
from utils.procthor_utils import Houses

@@ -369,7 +371,8 @@ def make_valid_houses_file(ctx, num_valid_houses=1_000, prefix="mini_val"):
)
num_used = 0
for scene in episodes:
print(scene)
if verbose:
print(scene)
pos = int(scene.split("_")[-1])
used_houses[pos] = houses._data[houses._mode][pos]
num_used += 1
@@ -379,7 +382,8 @@ def make_valid_houses_file(ctx, num_valid_houses=1_000, prefix="mini_val"):

compress_pickle.dump(used_houses, ofilename)

print("DONE")
if verbose:
print("DONE")


@task
@@ -721,7 +725,7 @@ def install_procthor_dataset(ctx, revision="2022procthor"):
)

print("Creating mini val houses file")
make_valid_houses_file(ctx)
make_valid_houses_file(ctx, verbose=False)

print("DONE")