Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace printing table with logging table #98

Merged
merged 1 commit into from
Nov 11, 2024
Merged

replace printing table with logging table #98

merged 1 commit into from
Nov 11, 2024

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Nov 11, 2024

I noticed this table gets printed during unit tests, muddling the pytest output. If we log the table instead of print it, it should still be rendered in the same way (due to our custom rich log handler), but will respect other logging settings.

@epwalsh epwalsh requested a review from undfined November 11, 2024 18:21
Copy link
Collaborator

@undfined undfined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@epwalsh epwalsh merged commit 6300bc7 into main Nov 11, 2024
13 of 14 checks passed
@epwalsh epwalsh deleted the epwalsh/log branch November 11, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants