Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed _bust_index_cache in one spot #78

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Missed _bust_index_cache in one spot #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e20ff05
Missed _bust_index_cache in one spot
undfined Nov 1, 2024
c69a3e3
Merge branch 'main' into undfined/clean-up
undfined Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/olmo_core/data/numpy_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ def _write_document_indices(self):
paths_needed: List[Tuple[PathOrStr, int]] = []
for idx, path in enumerate(self.paths):
indices_path = self._get_indices_path(path)
if indices_path.is_file() and not self._bust_index_cache:
if indices_path.is_file():
log.info(f"Reusing document indices for '{path}' at:\n'{indices_path}'")
elif path not in paths_needed:
paths_needed.append((path, idx))
Expand Down
Loading