Add BaseDataMix class #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
reviewed
Oct 9, 2024
| Base class for enumeration of data mixes. | ||
| """ | ||
|
|
||
| def build(self, base_dir: str, tokenizer: TokenizerName) -> Tuple[List[str], List[str]]: |
There was a problem hiding this comment.
Can you move the docstring for this method below to here?
src/olmo_core/data/mixes/__init__.py
Outdated
| @@ -7,10 +7,19 @@ | |||
|
|
|||
| from ..tokenizer import TokenizerName | |||
|
|
|||
| __all__ = ["DataMix"] | |||
| __all__ = ["BaseDataMix", "DataMix"] | |||
There was a problem hiding this comment.
Can you also export BaseDataMix in src/olmo_core/data/__init__.py?
epwalsh
reviewed
Oct 10, 2024
src/olmo_core/data/__init__.py
Outdated
| @@ -56,6 +56,7 @@ | |||
| "NumpyDatasetDType", | |||
| "TokenizerConfig", | |||
| "TokenizerName", | |||
| "BaseDataMix", | |||
There was a problem hiding this comment.
I think you're missing the actual import above
epwalsh
reviewed
Oct 10, 2024
src/olmo_core/data/mixes/__init__.py
Outdated
|
|
||
|
|
||
| class DataMix(StrEnum): | ||
| class BaseDataMix(StrEnum): |
There was a problem hiding this comment.
Oh, minor nit, but I've gone with the convention of calling base classes XXXBase instead of BaseXXX. Can you change this to DataMixBase?
epwalsh
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows extending the class to specify new mixes in projects using
olmo_core.