include clone commands in setup steps #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative to #61 that's a little more general |
AkshitaB
requested changes
Oct 7, 2024
|
Done: f1ca461 |
AkshitaB
reviewed
Oct 7, 2024
| 'git clone "${REPO_URL}" .', | ||
| 'git checkout "${GIT_REF}"', | ||
| "git submodule update --init --recursive", | ||
| "conda shell.bash activate base", |
There was a problem hiding this comment.
Looks like we do expect conda. If so, can we just define PRIVATE_REPO_SETUP_STEPS, and then it will Just Work ™ ?
There was a problem hiding this comment.
But this is just the default because we know conda will be on the default images.
AkshitaB
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.