Add support for MoE models #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And only use larger instance to build dev image
Muennighoff
approved these changes
Oct 12, 2024
Comment on lines
+118
to
+121
| bias: bool = True | ||
| """ | ||
| Include bias terms. | ||
| """ |
There was a problem hiding this comment.
We didn't use bias in OLMoE (like in the dense models) so could consider setting this to False
There was a problem hiding this comment.
We do set this to false in the actual 1B-7B config I cooked up, I just set the class default to True here to be consistent with the default for other model config classes.
| save_overwrite=True, | ||
| metrics_collect_interval=10, | ||
| cancel_check_interval=1, | ||
| z_loss_multiplier=1e-5, |
There was a problem hiding this comment.
Is this the z-loss for the softmax at the output? OLMoE trained without that if so
There was a problem hiding this comment.
Yes, I think we should try with both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.