KafkaReadinessCheckTest #1784
Merged
KafkaReadinessCheckTest #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrrzysko
force-pushed
the
slow_integration_tests
branch
from
39dc62b
to
e6336ea
Compare
piotrrzysko
force-pushed
the
slow_integration_tests
branch
from
e6336ea
to
ba9c6b4
Compare
druminski
approved these changes
Nov 20, 2023
Diewa
approved these changes
Nov 20, 2023
| getStatusHealth(hermesFrontend).expectStatus().is2xxSuccessful(); | ||
|
|
||
| // cleanup | ||
| kafka.makeClusterOperational(); |
There was a problem hiding this comment.
Just sharing my thoughts - I know that this method is not from this PR, but its name is quite general 🤔
There was a problem hiding this comment.
Do you have any suggestions on how to change it? Would startAllStoppedBrokers be better?
There was a problem hiding this comment.
in my opinion startAllStoppedBrokers is much better
There was a problem hiding this comment.
I'll change it in a separate PR
Diewa
approved these changes
Nov 21, 2023
druminski
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.