Allow adding arbitrary document code #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tin Lai <[email protected]>
allefeld
requested changes
Aug 26, 2023
| @@ -1117,6 +1121,7 @@ def _update(self): | |||
| # document body | |||
| codelines += [ | |||
| r'\begin{document}', | |||
| "\n".join(self.document_codes), | |||
There was a problem hiding this comment.
It would be nicer to insert the elements of the list instead of the combined string. I believe *self.document_code should do the trick.
| @@ -1080,6 +1081,9 @@ def usepackage(self, name, options=None): | |||
| code += '{' + name + '}' | |||
| self.add_preamble(code) | |||
|
|
|||
| def add_document_code(self, code): | |||
There was a problem hiding this comment.
Please add a docstring to the function, in the style of the other docstrings.
| @@ -1024,6 +1024,7 @@ def __init__(self, tempdir=None, cache=True, opt=None, **kwoptions): | |||
| super().__init__(opt=opt, **kwoptions) | |||
| # additional preamble entries | |||
| self.preamble = [] | |||
| self.document_codes = [] | |||
There was a problem hiding this comment.
Please insert a line comment on the line before explaining the purpose of the variable.
Also please call the variable document_code without the s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this PR as follows:
where
\tdplotsetmaincoords{70}{110}is not part of the preamble (which is supported currently), but it needs to be in-between