Skip to content

Commit

Permalink
test: ErrorBoundary dedicated directory and tests (apache#13276)
Browse files Browse the repository at this point in the history
* Add tests for ErrorBoundary

* Remove original ErrorBoundary file

* Prefer absolute path
  • Loading branch information
geido authored and Allan Caetano de Oliveira committed May 21, 2021
1 parent 98d1093 commit 0e8eaf1
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import { render, screen } from 'spec/helpers/testing-library';
import ErrorBoundary from '.';

const mockedProps = {
children: <span>Error children</span>,
onError: () => null,
showMessage: false,
};

const Child = () => {
throw new Error('Thrown error');
};

test('should render', () => {
const { container } = render(
<ErrorBoundary {...mockedProps}>
<Child />
</ErrorBoundary>,
);
expect(container).toBeInTheDocument();
});

test('should not render an error message', () => {
render(
<ErrorBoundary {...mockedProps}>
<Child />
</ErrorBoundary>,
);
expect(screen.queryByText('Unexpected error')).not.toBeInTheDocument();
});

test('should render an error message', () => {
const messageProps = {
...mockedProps,
showMessage: true,
};
render(
<ErrorBoundary {...messageProps}>
<Child />
</ErrorBoundary>,
);
expect(screen.getByText('Unexpected error')).toBeInTheDocument();
});
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import { t } from '@superset-ui/core';
import ErrorMessageWithStackTrace from './ErrorMessage/ErrorMessageWithStackTrace';
import ErrorMessageWithStackTrace from 'src/components/ErrorMessage/ErrorMessageWithStackTrace';

const propTypes = {
children: PropTypes.node.isRequired,
Expand Down

0 comments on commit 0e8eaf1

Please sign in to comment.