Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[risk=no] Upgrade jest to latest #4287

Merged
merged 4 commits into from
Nov 17, 2020
Merged

[risk=no] Upgrade jest to latest #4287

merged 4 commits into from
Nov 17, 2020

Conversation

calbach
Copy link
Contributor

@calbach calbach commented Nov 12, 2020

Why?

This produces much better stack traces for async error logs which get generated during testing. This is important with act() warnings, which have very vague descriptions and little-to-no stack trace on the prior version of Jest.

Changes:

  • Upgrade jest
  • move ts-jest from the main build to devDependencies. I don't know how/why it got in there
  • Kill off the main logspam source in tests: the "no gtag" error

@calbach calbach requested a review from dolbeew November 12, 2020 23:50
@calbach calbach force-pushed the ch/jest-upgrade branch 2 times, most recently from 4388852 to 57cefae Compare November 13, 2020 01:36
@calbach calbach force-pushed the ch/runtime-utils-test branch 2 times, most recently from 94706fd to ddf67d7 Compare November 16, 2020 20:57
Base automatically changed from ch/runtime-utils-test to master November 17, 2020 00:05
@calbach calbach merged commit 3441827 into master Nov 17, 2020
@calbach calbach deleted the ch/jest-upgrade branch November 17, 2020 01:20
calbach added a commit that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants