Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DC-3632] Remove irrelevant bq_utils import statements #1841

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

dev-michael-schmidt
Copy link
Contributor

@dev-michael-schmidt dev-michael-schmidt commented Jan 3, 2024

This PR removes several superfluous bq_utils imports. It removes 22 import statements where they are no longer needed. Since some files contain trailing whitespace, it may be hard to determine the actual, important change.

Luckily, most import statements occur at the beginning of each file; therefore, one may need to check only the first few lines! to see a removal using diff.

@dev-michael-schmidt dev-michael-schmidt marked this pull request as ready for review January 8, 2024 16:47
Copy link
Contributor

@lledezma lledezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR does not match the title of the ticket. I would update the title of the PR before merging.

Copy link
Contributor

@lledezma lledezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR does not match the title of the ticket. I would update the title of the PR before merging.

@dev-michael-schmidt dev-michael-schmidt changed the title [DC-3632] Remove five cases of unused imports [DC-3632] Remove irrelevant bq_utils import statements Jan 22, 2024
@dev-michael-schmidt dev-michael-schmidt merged commit 80c64b7 into develop Jan 22, 2024
4 checks passed
@dev-michael-schmidt dev-michael-schmidt deleted the ms/dc-3632 branch January 22, 2024 14:33
dev-michael-schmidt pushed a commit that referenced this pull request Jan 22, 2024
* [DC-3632] Remove five cases of unused imports

* [DC-3632] Update 5 more usages of imports, some formatting occurred

* [DC-3632] remove 5 more usages of imports, some formatting occurred

* [DC-3632] remove 5 more usages of imports, some formatting occurred

* [DC-3632] remove final 2 occurrences, some formatting occurred

* [DC-3632] Add required import back
dev-michael-schmidt pushed a commit that referenced this pull request Jan 22, 2024
* [DC-3632] Remove five cases of unused imports

* [DC-3632] Update 5 more usages of imports, some formatting occurred

* [DC-3632] remove 5 more usages of imports, some formatting occurred

* [DC-3632] remove 5 more usages of imports, some formatting occurred

* [DC-3632] remove final 2 occurrences, some formatting occurred

* [DC-3632] Add required import back
ratuagga pushed a commit that referenced this pull request Feb 2, 2024
* [DC-3632] Remove five cases of unused imports

* [DC-3632] Update 5 more usages of imports, some formatting occurred

* [DC-3632] remove 5 more usages of imports, some formatting occurred

* [DC-3632] remove 5 more usages of imports, some formatting occurred

* [DC-3632] remove final 2 occurrences, some formatting occurred

* [DC-3632] Add required import back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants