Ot 63 add slides to public endpoint #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link a JIRA: https://alkemy-labs.atlassian.net/browse/OT291-63 |
|
Y ver conflicto del dao |
|
Removido el console.log y resuelto el conflicto. |
devmontini
approved these changes
Sep 29, 2022
dao/slide.js
Outdated
| @@ -19,6 +19,19 @@ class SlidesDap { | |||
| throw new Error(error); | |||
| } | |||
| } | |||
| static async findSlidebyOrganization({ where, exclude = [], order = [] }) { | |||
| try { | |||
| console.log(where) | |||
soyarielruiz
approved these changes
Sep 30, 2022
| }); | ||
| response === null | ||
| ? res.status(404).json({ msg: 'Could not find information' }) | ||
| : res.status(200).json(response); | ||
| : res.status(200).json({ response, slides }); |
There was a problem hiding this comment.
nit: en vez de response usaría el nombre organization.
| }); | ||
| return SlideData; | ||
| } catch (error) { | ||
| throw new Error(error); |
There was a problem hiding this comment.
nit: Se pueden agregar excepciones custom para estos casos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AS user
I WANT to see Slides when I enter the page
TO be more informed about them
Criteria of acceptance:
In the public data endpoint of the Organization, the list of Slides ordered by the "order" field must be added.
The Slides will be those belonging to the Organization, based on the organization_id field that should correspond to the Organization that is being returned