Fix role middleware #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead two (req, res)
…n inclide property on sequelize query both isOwner and isAdminRole
| @@ -1,3 +1,4 @@ | |||
| node_modules | |||
| .env | |||
| docker-compose.yaml | |||
| docker_schemas | |||
There was a problem hiding this comment.
Esto está en otro PR.
| @@ -14,15 +12,19 @@ class RoleMiddleware { | |||
| } | |||
|
|
|||
| try { | |||
| const { email } = Token.decryptJWT(req, res); | |||
| const { email } = Token.decryptJWT(authToken); | |||
There was a problem hiding this comment.
Es más limpio centralizar el manejo de token en Token que es cada middleware, esto rompe encapsulación(peor de lo que estaba).
There was a problem hiding this comment.
@noisyBrain como es considerado un nit este caso y lo necesitan para seguir se aprueba.
soyarielruiz
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isOwner method
Ahora el método decrytJWT se le pasa un argumento (authToken) en vez de dos (req, res)
En la query de Sequelize:
En el attribute firstname se capitaliza la “N”, quedando como firstName
Se agregan los [] a la propiedad include
Se agrega el parámetro through antes de la búsqueda por atributos (attributes: ['name'])
En el condicional que comprueba el nombre del Rol del usuario que es hayado, se capitaliza la R, quedando if (user.Role.name) en lugar de if (user.role.name)
Se añade el email (que llega desde el token) a la req para luego desestructurarlo en el método getData del UserController.
La comprobación para saber si el id del usuario encontrado coincide con el id enviado por params se elimina ya que causa un bug en el flujo de trabajo, queda sujeto a revisión posterior.
isAdminRole
En la query de Sequelize:
En el attribute firstname se capitaliza la “N”, quedando como firstName
Se agregan los [] a la propiedad include
Se agrega el parámetro through antes de la búsqueda por atributos (attributes: ['name'])
En el condicional que comprueba el nombre del Rol del usuario que es hayado, se capitaliza la R, quedando if (user.Role.name) en lugar de if (user.role.name)
Se añade el email (que llega desde el token) a la req para luego desestructurarlo en el método getData del UserController.