OT 83 UPDATE COMMENT #128
Merged
OT 83 UPDATE COMMENT #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const resultUpdate = await CommentDao.updateComment({ id }, { body }); | ||
|
|
||
| return res.status(200).json({ |
There was a problem hiding this comment.
nit: Este return lo haría fuera del try
| @@ -84,6 +84,67 @@ class RoleMiddleware { | |||
|
|
|||
| return next(); | |||
| } | |||
| static async isOwnerOfComment(req, res, next) { | |||
There was a problem hiding this comment.
nit: isCommentOwner en vez de isOwnerOfComment
| } | ||
|
|
||
| try { | ||
| comment = await Comment.findOne({ |
There was a problem hiding this comment.
Esta lógica la podría tener el DAO o el controlador de comentarios, para centralizar lógica y mantener encapsulación.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isOwnerOfComment middleware added
update comment router and controller added