Avoid rendering <a> element

This has caused many issues, when an <a> element is created in this component there will be no way to support links, as nested <a> elements is offensive in the eyes of HTML. Closes mui#2178, mui#1979, mui#1823
alitaheri · Dec 30, 2015 · 24e43ea · 24e43ea
1 parent 947ad7d
commit 24e43ea
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/enhanced-button.jsx b/src/enhanced-button.jsx
@@ -195,9 +195,12 @@ const EnhancedButton = React.createClass({
     };
     const buttonChildren = this._createButtonChildren();
 
+    // Provides backward compatibity. Added to support wrapping around <a> element.
+    const targetLinkElement = buttonProps.hasOwnProperty('href') ? 'a' : 'span';
+
     return React.isValidElement(containerElement) ?
       React.cloneElement(containerElement, buttonProps, buttonChildren) :
-      React.createElement(linkButton ? 'a' : containerElement, buttonProps, buttonChildren);
+      React.createElement(linkButton ? targetLinkElement : containerElement, buttonProps, buttonChildren);
 
   },