Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper index versioning for backwards compatibility #975

Merged
merged 7 commits into from
Apr 9, 2022

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Apr 8, 2022

Currently we are emitting a hard error if either the index branch or version do not match.

With this PR, Alire knows the range of compatible versions (assuming we add features without breaking back compatibility), so now a warning is emitted for old compatible versions and mismatched branches. The error is only produced by a too old index version.

This should result in simpler switching between stable/devel versions, and also be less painful for people with private indexes whenever we add some new feature that does not break compatibility, as they're not forced to update their version on the spot.

@mosteo mosteo marked this pull request as ready for review April 8, 2022 15:41
@mosteo mosteo requested a review from Fabien-Chouteau April 8, 2022 15:41

procedure Compare_Branches (Local : String) is
Local_Kind : constant String := AAA.Strings.Head (Local, "-");
-- Local_Version : constant Semantic_Versioning.Version :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, good catch.

@mosteo mosteo merged commit 94ea95d into alire-project:master Apr 9, 2022
@mosteo mosteo deleted the feat/index-back branch April 9, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants