Bugfix for improper check related to virtual crates #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
commented
Oct 4, 2021
| if Dep.Has_Release and then Dep.Release.Provides (Dep.Crate) then | ||
| if Dep.Has_Release and then Dep.Release.Provides (Crate) then |
There was a problem hiding this comment.
This was the actual bug, ouch.
Fabien-Chouteau
approved these changes
Oct 4, 2021
|
I forgot in the review, but is there a tests that we can add to make sure doesn't happen again? |
|
I'll prepare a reproducer, but given the new assertions in the code the root problem will have to be from other quarters for this to happen again. |
mosteo
added a commit
that referenced
this pull request
Oct 10, 2021
mosteo
added a commit
that referenced
this pull request
Oct 12, 2021
* Test case for bug #875 (virtual crate environment) * Fix for test on Windows
|
@mosteo I feel like I hit this bug a lot. Should we make a patch release for it? |
|
Indeed. Only let me check that #880 is not affecting the 1.1 branch because that one would also nice to have fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.