Remove Alire.Requisites and Alire.Boolean_Trees #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a minor improvement for trees in which a vector with a single value is
promoted to the single value itself. As vectors are delimited by '(' ')', there
are a few test outputs that required eliminating these former extra
parentheses.
This allows more dead code removal and some further internal simplifications.
No longer needed, Requisites were useful in the old index for general expressions, but not anymore in our case-restricted index. Some quite obscure portions of Alire code can be thus removed.
It bugboxes anyway, so it's not currently usable
Fabien-Chouteau
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking advantage that we're early in the 2021 dev cycle, I'm doing a couple of internal refactorings that will ease new developments in the future.
This one is a preparatory step for #323. With our current index syntax, there are some parts of the expression logic that can be removed. Namely,
Alire.Requisitesand its dependencies is no longer needed after a few tweaks. This also removes some complex logic about requisites <-> properties interactions. Also, dependencies/properties/availability all share the expression code now whereas availability before was separate.Also some dead code for if/then/else expressions has been removed.