Use local repository as reference for publishing #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 tasks
mosteo
force-pushed
the
feat/pub-local-repo
branch
from
b9ed092 to
7025c4e
Compare
mosteo
force-pushed
the
feat/check-build
branch
from
abf5ad3 to
a47ff0d
Compare
mosteo
force-pushed
the
feat/pub-local-repo
branch
6 times, most recently
from
0e9111d to
99a1a3a
Compare
Fabien-Chouteau
approved these changes
Sep 11, 2020
mosteo
force-pushed
the
feat/check-build
branch
from
a47ff0d to
8e205bc
Compare
mosteo
force-pushed
the
feat/pub-local-repo
branch
from
99a1a3a to
4449565
Compare
mosteo
force-pushed
the
feat/check-build
branch
from
8e205bc to
001eb32
Compare
We still require the remote is ready (in essence, that the local repo is not ahead of the remote), but now it is simply a matter of issuing `alr publish` or `alr publish <commit|tag|branch>`, and the corresponding commit will be used.
Adding defaults for <URL> <commit> complicates things somewhat as we use local paths for testing that would otherwise be rejected, so a few corner cases have to be explicitly considered now.
mosteo
force-pushed
the
feat/pub-local-repo
branch
from
4449565 to
5b9b593
Compare
Fabien-Chouteau
pushed a commit
that referenced
this pull request
Sep 23, 2020
* Publish using local repo and revision as reference We still require the remote is ready (in essence, that the local repo is not ahead of the remote), but now it is simply a matter of issuing `alr publish` or `alr publish <commit|tag|branch>`, and the corresponding commit will be used. * Refactor long function name to more sensible one * Fix comments due to bad refactoring * Test for publishing from inside a repo * Fixes uncovered by testsuite Adding defaults for <URL> <commit> complicates things somewhat as we use local paths for testing that would otherwise be rejected, so a few corner cases have to be explicitly considered now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the shortcuts described in #512 in this comment to use the local repository as reference for publishing.
We accept:
alr publish [<path> [revision]]Default revision is
HEADand default path is.. The revision is converted to its commit, so it works for (local) tags and branches too. Then we continue as in #512 with the remote origin URL and the commit.We check the path to be inside a root that is also a clean git repository.
With this PR I'd say we have a complete "phase 2" (#227), that is, assisted publishing when the remote is ready, so I'd say to write tests for the PRs that are currently open and merge all of them together.