-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer uninstalled compiler as fallback with warning #1508
Conversation
This is after checking that the preferred compiler cannot fulfill the compiler dependency.
It should have been real all along without alternatives
c8f2673
to
100fc0b
Compare
Hi @mosteo ,
I am not sure about this error message because it doesn't provide a way forward. |
The way forward is simply accepting the solution, and the dependency will be installed normally as a toolchain (as happens currently for explicit compiler dependencies like This situation happens when a solution ( |
Ok so right now Alire would just show an incomplete solution, but not download the compiler even if it knows how to.
To me this message is telling the user that something went wrong and there's nothing Alire can do about it. So maybe we should remove the exclamation mark and the message could be |
Yeah, that's the gist of it. |
New message:
|
This one may be controversial.
Currently, we will not try to satisfy a
gnat
dependency with an uninstalled compiler (specific dependencies likegnat_arm_elf
do not fall into this case, only the abstractgnat
ones), instead reporting a missing dependency:This doesn't seem very intuitive, as nothing says that installing the proper compiler version would fix the issue. With this PR an installed compiler is still chosen first for the dependency but, when none fits, this will happen: