Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some hardcoded externals to hash input #1440

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Add some hardcoded externals to hash input #1440

merged 1 commit into from
Sep 4, 2023

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Sep 1, 2023

These are used but never declared. I'm not 100% sure this is needed.

@mosteo mosteo marked this pull request as ready for review September 1, 2023 07:45
Fabien-Chouteau
Fabien-Chouteau approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@Fabien-Chouteau Fabien-Chouteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory they produce different outputs, but it could re-trigger the builds of all the units so it's probably good to include them.

@mosteo mosteo changed the base branch from feat/hash-dependencies to master September 4, 2023 09:30
@mosteo mosteo force-pushed the feat/hash-hardcoded branch from dc6c735 to abe5ccf Compare September 4, 2023 16:28
@mosteo mosteo merged commit 3a2268e into master Sep 4, 2023
@mosteo mosteo deleted the feat/hash-hardcoded branch September 4, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabien-Chouteau Fabien-Chouteau Fabien-Chouteau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosteo @Fabien-Chouteau