Improvements to publishing with automatic PR creation #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow our testing and help maintainers of other indexes
Fabien-Chouteau
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
That looks promising :)
Two comments:
- I would love to see a comment explaining the whole process somewhere in the code. It looks fairly complex between the clone, commit and API calls.
- I think this should be a question at the end of
alr publishrather than a switch.
mosteo
changed the title
alr publish --submitAlso use a better name for the new child package.
Document this change in behavior and the new `--skip-submit` switch that restores the former behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few steps to the assistant that will end in the PR being opened without having to upload the manifest manually.
From the user PoV, this PR boils down to using
alr publish --submit.This is still lacking tests as we may want to tweak the workflow and in any case it will require some more instrumentation to allow dry runs and local impersonation of the community index, and there's already quite some amount of new code. So I would submit the tests in a follow-up.
Having now used the GitHub REST API, it will be easy to improve on this core functionality to allow status tracking and maybe some limited interaction (like requesting a review once checks pass) also from the command line (something like
alr publish --request-review | --status | --cancel), so for the common case it could all be managed throughalr.This should both simplify submissions and also some people have claimed for automation of the process (people already involved in packaging for distros).
For example, I created alire-project/alire-index#840 with this.