Typed variants of Alire.Config.Edit.Set #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +23,23 @@ package Alire.Config.Edit is | |||
| Value : String; | |||
| Check : CLIC.Config.Check_Import := null); | |||
|
|
|||
| -- Typed alternatives | |||
|
|
|||
| procedure Set_Boolean (Level : Config.Level; | |||
There was a problem hiding this comment.
Are these used somewhere?
There was a problem hiding this comment.
Not yet, but there are old uses of Set that could be migrated
mosteo
force-pushed
the
feat/typed-config-set
branch
from
ab70c71 to
919b8b0
Compare
Mostly because it's too easy to mix Boolean with String
mosteo
force-pushed
the
feat/typed-config-set
branch
from
919b8b0 to
8abeff9
Compare
mosteo
force-pushed
the
feat/typed-config-set
branch
from
4ac82bf to
c758f80
Compare
Fabien-Chouteau
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly because it's too easy to mix Boolean with String now.