Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow dots in identifiers #1267

Merged
merged 8 commits into from
Jan 18, 2023
Merged

Disallow dots in identifiers #1267

merged 8 commits into from
Jan 18, 2023

Conversation

0rzech
Copy link
Contributor

@0rzech 0rzech commented Dec 11, 2022

Fixes #1076.

@0rzech 0rzech force-pushed the disallow-crate-names-with-leading-dot branch 8 times, most recently from 124e8a6 to 815fe9a Compare December 12, 2022 01:42
@0rzech 0rzech changed the title Disallow crate names with leading dot Disallow identifiers with leading dot Dec 12, 2022
@0rzech 0rzech force-pushed the disallow-crate-names-with-leading-dot branch 3 times, most recently from b843752 to 3a99f23 Compare December 12, 2022 02:06
@0rzech
Disallow leading dot in identifiers
a6bca92 
This is to avoid `alr printenv` printing invalid
environment variable names, i.e. with leading dot.
@0rzech 0rzech force-pushed the disallow-crate-names-with-leading-dot branch from 3a99f23 to e8da696 Compare December 12, 2022 02:31
@0rzech 0rzech force-pushed the disallow-crate-names-with-leading-dot branch from e8da696 to ca5d04d Compare December 12, 2022 02:35
@0rzech 0rzech force-pushed the disallow-crate-names-with-leading-dot branch from ca5d04d to a4937b8 Compare December 12, 2022 02:35
@Fabien-Chouteau
Copy link
Member

@mosteo I didn't know we still allowed dots in crate names.

@mosteo
Copy link
Member

mosteo commented Dec 13, 2022

This must have slipped through the cracks; it was certainly unintended at this point.

@mosteo
Copy link
Member

mosteo commented Dec 13, 2022

So the proper patch would be to remove these extension separator remains in alire.ads, not to document it, sorry @0rzech.

I'm quite surprised this has gone unnoticed for so long.

@0rzech
Disallow dots in identifiers
891d1c1 
Dots in identifiers are allowed by mistake.
This commit forbids them completely, instead
of just disallowing dots as the first character
in crate name.
@0rzech 0rzech changed the title Disallow identifiers with leading dot Disallow dots in identifiers Dec 13, 2022
@0rzech
Copy link
Contributor Author

0rzech commented Dec 13, 2022 •
edited
Loading

@mosteo No problemo. 😉 I've removed support for dots in identifiers completely. This affects index names too. I'm not sure if we want that as well, though.

@mosteo
Copy link
Member

mosteo commented Jan 18, 2023

Thanks for the patience, @0rzech

@mosteo mosteo merged commit 191656f into alire-project:master Jan 18, 2023
@0rzech 0rzech deleted the disallow-crate-names-with-leading-dot branch January 18, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabien-Chouteau Fabien-Chouteau Fabien-Chouteau approved these changes

@mosteo mosteo mosteo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow identifiers starting with dots
3 participants
@0rzech @Fabien-Chouteau @mosteo