Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hyphens for action usage output #1249

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

0rzech
Copy link
Contributor

@0rzech 0rzech commented Nov 24, 2022

Currently action usage output looks like:
alr action [options] [post_fetch|pre_build|post_build|test],
but it should look like:
alr action [options] [post-fetch|pre-build|post-build|test],
because TOML expects keys to be hyphenated.

This PR fixes #1230 by replacing underscores with hyphens.

@0rzech 0rzech force-pushed the hyphens-in-action-usage-output branch 3 times, most recently from 466f688 to e97b1db Compare November 24, 2022 01:30
Currently action usage output looks like:
`alr action [options] [post_fetch|pre_build|post_build|test]`,
but it should look like:
`alr action [options] [post-fetch|pre-build|post-build|test]`,
because TOML expects keys to be hyphenated.

This commit fixes the problem by replacing underscores with hyphens.
@0rzech 0rzech force-pushed the hyphens-in-action-usage-output branch from e97b1db to b5d859b Compare November 24, 2022 01:34
@0rzech 0rzech changed the title Use hyphens for action's usage output Use hyphens for action usage output Nov 24, 2022
@mosteo
Copy link
Member

mosteo commented Nov 24, 2022

Merged, thanks @0rzech

@mosteo mosteo merged commit 5962cab into alire-project:master Nov 24, 2022
@0rzech 0rzech deleted the hyphens-in-action-usage-output branch November 24, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use hyphens instead of underscores
2 participants