Alire.Crate.Configuration: disable style checks in generated code #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current style checks it is easy to break coding style by having to many values in an enum for instance. In theory we could generate better code for enums. But since users can use their own coding style, it is impossible to be compatible with in every situation. So the best option is to disable all checks for this file.
mosteo
approved these changes
Jun 8, 2022
|
@mosteo something we can push to the |
|
OK, I'll apply it and we can push out a 1.2.1 |
|
Not sure it's worth a .1 yet. |
|
Yeah, we can wait for a while so things consolidate a bit. I also had the GNAT Studio message in mind, thanks for the reminder. |
mosteo
pushed a commit
that referenced
this pull request
Jun 8, 2022
) With the current style checks it is easy to break coding style by having to many values in an enum for instance. In theory we could generate better code for enums. But since users can use their own coding style, it is impossible to be compatible with in every situation. So the best option is to disable all checks for this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current style checks it is easy to break coding style by having
to many values in an enum for instance.
In theory we could generate better code for enums. But since users can
use their own coding style, it is impossible to be compatible with in
every situation.
So the best option is to disable all checks for this file.