Added intelligent AMF selection at gNB #731

priyanshs · 2024-09-23T06:49:42Z

Fixed the issue of gNB randomly routing registration requests to an arbitrary AMF, without considering the slice type requested by the UE and the slice types served by the AMF.
Extended the gNB to select AMF intelligently based on the type of slice requested by the UE.

…lection Added intelligent AMF selection at gNB

priyanshs · 2024-09-23T08:57:01Z

@aligungr, please advise if we need to make further changes to this implementation. We tried connecting UEs with the same PLMN but on different slices, and it failed. The changes we made were to select AMF from the list.

Thanks

priyanshs · 2024-10-15T08:57:19Z

@aligungr please have a look at the PR and let us know if we need to make further changes. It would be nice if we could merge with the master branch.
Thanks

uchiha-Itachi-kanoha · 2024-10-15T09:06:38Z

@priyanshs i have a query, does the UERANSIM supports IPsec ?

aligungr · 2024-10-30T13:50:30Z

src/utils/octet.hpp

@@ -25,6 +25,11 @@ struct octet
    {
    }

+    inline uint8_t getValue() const


Please remove this function.

You can directly cast to uint8_t in order to convert octet to uint8_t

uint8_t aaa = (uint8_t)bbb;

I have used the getValue() getter method here as value is a private variable of struct octet and this appeared to me as the most appropriate way to access the value variable from outside, i.e., in the extractSliceInfoAndModifyPdu method. Please let me know, if there is a more recommended way.

octet has a special converter for uint8_t. Please directly use this converter, and remove the getValue().

Example:

octet someOctet = .... uint8_t someUint8 = (uint8_t)someOctet

aligungr · 2024-10-30T13:52:06Z

src/utils/octet_string.hpp

@@ -25,6 +25,11 @@ class OctetString
    {
    }

+    const std::vector<uint8_t>& getData() const


data is already present. Please remove this method.

I believe I used this getter() as m_data was a private member of the Octetstring class and for extractSliceInfoAndModifyPdu(), I needed the data from NAS PDU. Please let me know, if there is a more suitable alternative.

Yes m_data is private, however we have public data() function. Please use data() function instead.

aligungr · 2024-10-30T13:52:31Z

src/ue/nas/mm/messaging.cpp

@@ -73,7 +73,6 @@ static void RemoveCleartextIEs(nas::PlainMmMessage &msg, OctetString &&nasMsgCon
        regReq.micoIndication = std::nullopt;
        regReq.networkSlicingIndication = std::nullopt;
        regReq.mmCapability = std::nullopt;
-        regReq.requestedNSSAI = std::nullopt;


Could you explain this remove?

This is to prevent the UE from removing Slice information, before sending the NAS PDU. It is in reference to the comment here.

aligungr · 2024-10-30T13:53:16Z

src/gnb/ngap/nnsf.cpp

-    for (auto &amf : m_amfCtx)
-        return amf.second; // return the first one
+    for (auto &amf : m_amfCtx) {
+        for (const auto &PlmnSupport : amf.second->plmnSupportList) {


Please use lower-case for SingleSlice and SingleSlice. Because they are loop variables.

I see. Will do that.

Please rename const auto &PlmnSupport to const auto &plmnSupport

and

const auto &SingleSlice to const auto &singleSlice

And please replace const int32_t &requestedSliceType to just int32_t requestedSliceType

aligungr · 2024-10-30T13:53:48Z

src/gnb/ngap/nas.cpp


 namespace nr::gnb
 {

-void NgapTask::handleInitialNasTransport(int ueId, const OctetString &nasPdu, int64_t rrcEstablishmentCause,
-                                         const std::optional<GutiMobileIdentity> &sTmsi)
+int32_t extractSliceInfoAndModifyPdu(OctetString &nasPdu) {


Could you explain why the modification is needed for the original PDU

Yes sure. In the current implementation, the UE is removing the information elements (including slice information), before sending the NAS PDU to gNB [ RemoveCleartextIEs() ]. gNB then selects one AMF blindly and forwards the request to the selected AMF.

Now, to support intelligent AMF selection based on slice type, I have prevented removal of slice info from the PDU, when the UE sends it. Now, at the gNB end, the gNB uses this slice info., to select an appropriate AMF. Before forwarding the PDU to AMF, I had to remove the slice information from the PDU at gNB, else it leads to a "Unsupported Message Type received" error on AMF end.

aligungr · 2024-10-30T13:54:41Z

@priyanshs

Thanks for the pull request. I've completed the first review. Could you please look the comments above?

aligungr · 2024-11-14T18:45:39Z

Sorry for the late reply. I have some more comments. Please see. Thanks

aligungr · 2024-11-14T18:41:10Z

src/gnb/ngap/nnsf.cpp

-    for (auto &amf : m_amfCtx)
-        return amf.second; // return the first one
+    for (auto &amf : m_amfCtx) {
+        for (const auto &PlmnSupport : amf.second->plmnSupportList) {


Please rename const auto &PlmnSupport to const auto &plmnSupport

and

const auto &SingleSlice to const auto &singleSlice

And please replace const int32_t &requestedSliceType to just int32_t requestedSliceType

aligungr · 2024-11-14T18:41:35Z

src/gnb/ngap/task.hpp

@@ -71,7 +71,7 @@ class NgapTask : public NtsTask
    /* Utility functions */
    void createAmfContext(const GnbAmfConfig &config);
    NgapAmfContext *findAmfContext(int ctxId);
-    void createUeContext(int ueId);
+    void createUeContext(int ueId, const int32_t &requestedSliceType);


Also make just int32_t requestedSliceType

aligungr · 2024-11-14T18:41:51Z

src/gnb/ngap/task.hpp

@@ -118,7 +118,7 @@ class NgapTask : public NtsTask
    void sendContextRelease(int ueId, NgapCause cause);

    /* NAS Node Selection */
-    NgapAmfContext *selectAmf(int ueId);
+    NgapAmfContext *selectAmf(int ueId, const int32_t &requestedSliceType);


Same thing please

aligungr · 2024-11-14T18:43:06Z

src/utils/octet_string.hpp

@@ -25,6 +25,11 @@ class OctetString
    {
    }

+    const std::vector<uint8_t>& getData() const


Yes m_data is private, however we have public data() function. Please use data() function instead.

aligungr · 2024-11-14T18:44:59Z

src/utils/octet.hpp

@@ -25,6 +25,11 @@ struct octet
    {
    }

+    inline uint8_t getValue() const


octet has a special converter for uint8_t. Please directly use this converter, and remove the getValue().

Example:

octet someOctet = .... uint8_t someUint8 = (uint8_t)someOctet

prateekbhaisora and others added 2 commits September 23, 2024 12:09

added intelligent AMF selection at gNB

2da35a6

Merge pull request #1 from prateekbhaisora/feature/intelligent-amf-se…

90c4026

…lection Added intelligent AMF selection at gNB

aligungr requested changes Oct 30, 2024

View reviewed changes

priyanshs requested a review from aligungr November 7, 2024 07:52

aligungr requested changes Nov 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added intelligent AMF selection at gNB #731

Added intelligent AMF selection at gNB #731

priyanshs commented Sep 23, 2024

priyanshs commented Sep 23, 2024

priyanshs commented Oct 15, 2024

uchiha-Itachi-kanoha commented Oct 15, 2024

aligungr Oct 30, 2024

prateekbhaisora Oct 30, 2024 •

edited

Loading

aligungr Nov 14, 2024

aligungr Oct 30, 2024

prateekbhaisora Oct 30, 2024 •

edited

Loading

aligungr Nov 14, 2024

aligungr Oct 30, 2024

prateekbhaisora Oct 30, 2024

aligungr Oct 30, 2024

prateekbhaisora Oct 30, 2024

aligungr Nov 14, 2024

aligungr Oct 30, 2024

prateekbhaisora Oct 30, 2024 •

edited

Loading

aligungr commented Oct 30, 2024

aligungr commented Nov 14, 2024

aligungr Nov 14, 2024

aligungr Nov 14, 2024

aligungr Nov 14, 2024

aligungr Nov 14, 2024

aligungr Nov 14, 2024

Added intelligent AMF selection at gNB #731

Are you sure you want to change the base?

Added intelligent AMF selection at gNB #731

Conversation

priyanshs commented Sep 23, 2024

priyanshs commented Sep 23, 2024

priyanshs commented Oct 15, 2024

uchiha-Itachi-kanoha commented Oct 15, 2024

Choose a reason for hiding this comment

prateekbhaisora Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prateekbhaisora Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prateekbhaisora Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

aligungr commented Oct 30, 2024

aligungr commented Nov 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prateekbhaisora Oct 30, 2024 •

edited

Loading

prateekbhaisora Oct 30, 2024 •

edited

Loading

prateekbhaisora Oct 30, 2024 •

edited

Loading