MICRO-50: Support step through debug with VSCode #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kai-nguyen-aligent
requested review from
TheOrangePuff,
AdamJHall,
tvhees and
SamMenzel
|
@tvhees I'm looking into supporting the same functionality for PHPStorm but probably will be another PR. |
TheOrangePuff
requested changes
Dec 7, 2022
| @@ -4,6 +4,8 @@ | |||
| "description": "Serverless ESBuild example using Typescript", | |||
| "main": "handler.js", | |||
| "scripts": { | |||
| "debug-test": "node --inspect=0.0.0.0 ./node_modules/.bin/jest --runInBand", | |||
| "debug-invoke-local": "MINIFY=false SOURCEMAP=true node --inspect=0.0.0.0 ./node_modules/.bin/serverless invoke local", | |||
There was a problem hiding this comment.
Can ./node_modules/.bin/serverless be changed to use the serverless docker image? We want to avoid confusion for developers where something might work when they run the serverless command but doesn't work when they run serverless from node_modules.
There was a problem hiding this comment.
@TheOrangePuff : Yes, we can do that. However, I'm not sure if we should do it though. The problem here is that anytime you run serverless command from inside your project, node will use the locally installed package instead of the global one as shown below:
$ cat ~/.aligent_aliases
alias node-run='docker run --rm -it -v ~/.aws:/home/node/.aws -v ~/.azure:/home/node/.azure -v ~/.npm:/home/node/.npm -v "$PWD:/app" aligent/serverless:latest'
alias serverless='node-run serverless'
$ serverless --version
Framework Core: 3.22.0
Plugin: 6.2.2
SDK: 4.3.2
$ cd ./serverless-aws-nodejs-service-template
$ rm -rf node_modules
$ node-run npm ci
$ serverless --version
Running "serverless" from node_modules
Framework Core: 3.18.2 (local) 3.22.0 (global)
Plugin: 6.2.2
SDK: 4.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the ability to debug lambda function with VSCode. There are couple of notes as listed below:
aligent/serverless:debugdocker container for debugging purpose.sourcemapand disableminifythrough environment variable when building withesbuildto support debugging byinvoke local.invoke localto debug. After a code change, the first time we try to debug withinvoke local, VSCode will fail to attach to the debugger. This happens becauseserverlesswill not build our code until we trigger that invocation. All the sub sequence launches will success and we will be able to attach to the debugger normally.