🔧 chore: early return if empty value

aligent · Mar 18, 2024 · 6816c29 · 6816c29
1 parent ae5ec76
commit 6816c29
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/Model/Indexer/LuceneSearch.php b/Model/Indexer/LuceneSearch.php
@@ -54,16 +54,16 @@ public function prepare(): void
     {
         $value = $this->getContext()->getRequestParam('search');
 
+        if (empty($value)) {
+            return;
+        }
+
         if ($this->asyncEventsConfig->isIndexingEnabled()) {
             $client = $this->connectionManager->getConnection();
             $indexPrefix = $this->config->getIndexPrefix();
             $filter = $this->filterBuilder->setConditionType('in')
                 ->setField($this->getName());
 
-            if ($value === "") {
-                return;
-            }
-
             try {
                 $rawResponse = $client->query(
                     [
@@ -88,15 +88,12 @@ public function prepare(): void
                 $filter->setValue("0");
             }
 
-            $this->getContext()->getDataProvider()->addFilter($filter->create());
         } else {
-            if ((string)$value !== '') {
-                $filter = $this->filterBuilder->setConditionType('like')
-                    ->setField('serialized_data')
-                    ->setValue($value);
-
-                $this->getContext()->getDataProvider()->addFilter($filter->create());
-            }
+            $filter = $this->filterBuilder->setConditionType('like')
+                ->setField('serialized_data')
+                ->setValue($value);
         }
+
+        $this->getContext()->getDataProvider()->addFilter($filter->create());
     }
 }