Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MI-111 adding contribution, code of conduct, PR template docs #30

Merged
merged 7 commits into from
Jan 31, 2025
Merged

MI-111 adding contribution, code of conduct, PR template docs #30

merged 7 commits into from
Jan 31, 2025

Conversation

ryanrixxh
Copy link
Contributor

Adding basic contribution notes :)

@ryanrixxh ryanrixxh added the documentation Improvements or additions to documentation label Nov 11, 2024
@ryanrixxh ryanrixxh self-assigned this Nov 11, 2024
@ryanrixxh ryanrixxh requested a review from a team as a code owner November 11, 2024 23:03
TheOrangePuff
TheOrangePuff requested changes Nov 13, 2024
View reviewed changes
docs/pull_request_template.md Outdated Show resolved Hide resolved
docs/pull_request_template.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
@tvhees
Copy link
Contributor

tvhees commented Nov 20, 2024

@ryanrixxh I think this is the right direction for Aligent but want to be clear about what we're signing ourselves up for with the code of conduct in particular.

tvhees
tvhees reviewed Nov 20, 2024
View reviewed changes
docs/CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
@ryanrixxh
Copy link
Contributor Author

ryanrixxh commented Dec 20, 2024 •
edited
Loading

@TheOrangePuff @tvhees

As per our discussions I've made the small fix-ups necessary for an initial code of conduct / contribution guideline.

For anything addressing more philosophical concerns in this documentation I leave it to the principals to discuss and determine how best we move forward with conduct and contribution guidelines.

tvhees
tvhees approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@tvhees tvhees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvhees
Copy link
Contributor

tvhees commented Jan 29, 2025

@ryanrixxh @TheOrangePuff we now have a repository for standard code of conduct etc.: https://github.com/aligent/code-of-conduct/tree/main

Can we just link to that from the CODE_OF_CONDUCT and CONTRIBUTING files? I assume the pull request template needs to actually be in this repository.

@TheOrangePuff
Copy link
Contributor

@tvhees yep pull request template has to be in the repo but we can link to everything else 🙂

TheOrangePuff
TheOrangePuff requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the comment by @tvhees , we should be linking to the code of conduct repo now

@tvhees tvhees requested a review from TheOrangePuff January 31, 2025 03:37
TheOrangePuff
TheOrangePuff approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvhees tvhees merged commit 608759e into main Jan 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvhees tvhees tvhees approved these changes

@TheOrangePuff TheOrangePuff TheOrangePuff approved these changes

Assignees

@ryanrixxh ryanrixxh

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanrixxh @tvhees @TheOrangePuff