Merge pull request #1042 from alicevision/fix/loading3DExternalFiles

[ui] Viewer3D: fix loading external files
alicevision · Aug 24, 2020 · 5a6f94e · 5a6f94e
2 parents 04c21ff + 65138c6
commit 5a6f94e
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/meshroom/ui/qml/Viewer3D/MediaLibrary.qml b/meshroom/ui/qml/Viewer3D/MediaLibrary.qml
@@ -203,14 +203,12 @@ Entity {
                 property string rawSource: attribute ? attribute.value : model.source
                 // whether dependencies are statified (applies for output/connected input attributes only)
                 readonly property bool dependencyReady: {
-                    if(!attribute)
-                        // if the node is removed, the attribute will be invalid
-                        return false
-
-                    const rootAttribute = attribute.isLink ? attribute.rootLinkParam : attribute
-                    if(rootAttribute.isOutput)
-                        return rootAttribute.node.globalStatus === "SUCCESS"
-                    return true // is an input param so no dependency
+                    if(attribute) {
+                        const rootAttribute = attribute.isLink ? attribute.rootLinkParam : attribute
+                        if(rootAttribute.isOutput)
+                            return rootAttribute.node.globalStatus === "SUCCESS"
+                    }
+                    return true // is an input param without link (so no dependency) or an external file
                 }
                 // source based on raw source + dependency status
                 property string currentSource: dependencyReady ? rawSource : ""