Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sfm] Performance improvements: optimize RemoveOutliers_AngleError #841

Merged
merged 5 commits into from
Sep 2, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/aliceVision/camera/IntrinsicBase.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,8 @@ class IntrinsicBase
};

/**
* @brief Return the angle (degree) between two bearing vector rays
* @brief Apply intrinsic and extrinsic parameters to unit vector
* from the cameras focus to a point on the camera plane
* @param[in] pose Extrinsic pose
* @param[in] intrinsic Intrinsic camera paremeters
* @param[in] x Point in image
Expand Down
2 changes: 1 addition & 1 deletion src/aliceVision/sfm/sfmFilters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ IndexT RemoveOutliers_AngleError(sfmData::SfMData& sfmData, const double dMinAcc

// Greedy algorithm almost always finds an acceptable angle in 1-5 iterations (if it exists).
// It works by greedily chasing the first larger view angle found from the current greedy index.
// View angles have a spartial distribution, so greedily jumping over larger and larger angles
// View angles have a sparial distribution, so greedily jumping over larger and larger angles
fabiencastan marked this conversation as resolved.
Show resolved Hide resolved
// forces the greedy index towards the outside of the distribution.
double dGreedyCos = 1.1;
Eigen::Matrix<double, 3, Eigen::Dynamic>::Index greedyI = 0;
fabiencastan marked this conversation as resolved.
Show resolved Hide resolved
Expand Down